Update logback and logstash dependencies #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow
bot
added
approved
|
/hold I'll double check if logging is still visible as we had issues in the past |
knative-prow
bot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
=======================================
Coverage 45.44% 45.44%
=======================================
Files 270 270
Lines 19893 19893
=======================================
Hits 9041 9041
Misses 10133 10133
Partials 719 719 ☔ View full report in Codecov by Sentry. |
|
Logs are emitted /unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/test integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
merged commit e1e20b7
into
knative-extensions:main
30 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title