Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps to latest #4226

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Update deps to latest #4226

merged 5 commits into from
Jan 23, 2025

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 23, 2025

@knative-prow knative-prow bot requested review from creydr and pierDipi January 23, 2025 09:41
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 17.03704% with 224 lines in your changes missing coverage. Please review.

Project coverage is 47.33%. Comparing base (e56cd44) to head (e915258).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ned/typed/sources/v1beta1/fake/fake_kafkasource.go 0.00% 27 Missing ⚠️
...ersioned/typed/sources/v1/fake/fake_kafkasource.go 18.51% 22 Missing ⚠️
...sioned/typed/bindings/v1/fake/fake_kafkabinding.go 0.00% 21 Missing ⚠️
...d/typed/bindings/v1beta1/fake/fake_kafkabinding.go 0.00% 21 Missing ⚠️
...ned/typed/eventing/v1alpha1/fake/fake_kafkasink.go 23.80% 16 Missing ⚠️
.../typed/messaging/v1beta1/fake/fake_kafkachannel.go 23.80% 16 Missing ⚠️
...skafkaeventing/v1alpha1/fake/fake_consumergroup.go 44.44% 15 Missing ⚠️
...ernalskafkaeventing/v1alpha1/fake/fake_consumer.go 42.85% 12 Missing ⚠️
...d/internalskafkaeventing/v1alpha1/consumergroup.go 0.00% 11 Missing ⚠️
...lientset/versioned/typed/sources/v1/kafkasource.go 0.00% 11 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4226      +/-   ##
==========================================
+ Coverage   45.44%   47.33%   +1.88%     
==========================================
  Files         270      270              
  Lines       19893    19011     -882     
==========================================
- Hits         9041     8998      -43     
+ Misses      10133     9300     -833     
+ Partials      719      713       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Jan 23, 2025

/test upgrade-tests

@skonto
Copy link
Contributor Author

skonto commented Jan 23, 2025

/test channel-integration-tests-sasl-ssl

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
Copy link

knative-prow bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b4d2bc2 into knative-extensions:main Jan 23, 2025
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants