Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken symlink to deprecated resource configs #4233

Conversation

dsimansk
Copy link
Contributor

Fixes #

Proposed Changes

  • Remove broken symlink to deprecated resource configs

Cherry-pick to release-1.17 of the original PR: #4232

Release Note

Remove broken symlink to deprecated resource configs

/cc @pierDipi @creydr @knative-extensions/knative-release-leads

@knative-prow knative-prow bot requested review from creydr, pierDipi, a team and skonto and removed request for a team January 26, 2025 12:29
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/control-plane labels Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.33%. Comparing base (5c18227) to head (154c4a0).
Report is 1 commits behind head on release-1.17.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.17    #4233      +/-   ##
================================================
- Coverage         47.34%   47.33%   -0.02%     
================================================
  Files               270      270              
  Lines             19011    19011              
================================================
- Hits               9001     8998       -3     
- Misses             9298     9300       +2     
- Partials            712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2025
Copy link

knative-prow bot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor Author

/retest

@dsimansk
Copy link
Contributor Author

/test upgrade-tests

Copy link

knative-prow bot commented Jan 27, 2025

@dsimansk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests_eventing-kafka-broker_release-1.17 154c4a0 link unknown /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member

pierDipi commented Feb 3, 2025

Done in #4234

@pierDipi pierDipi closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants