Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CE Java SDK to 4.0.1 #4235

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

pierDipi
Copy link
Member

As per title

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot requested review from aliok and Cali0707 January 27, 2025 09:01
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (6effb48) to head (b09a837).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4235   +/-   ##
=======================================
  Coverage   45.32%   45.32%           
=======================================
  Files         290      290           
  Lines       19869    19869           
=======================================
  Hits         9005     9005           
  Misses      10151    10151           
  Partials      713      713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@Cali0707
Copy link
Member

/retest-required

Copy link

knative-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 331f951 into knative-extensions:main Jan 27, 2025
30 of 33 checks passed
@knative-prow-robot
Copy link
Contributor

@pierDipi: #4235 failed to apply on top of branch "release-1.15":

Applying: Bump CE Java SDK to 4.0.1
Using index info to reconstruct a base tree...
M	data-plane/THIRD-PARTY.txt
M	data-plane/pom.xml
Falling back to patching base and 3-way merge...
Auto-merging data-plane/pom.xml
CONFLICT (content): Merge conflict in data-plane/pom.xml
Auto-merging data-plane/THIRD-PARTY.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Bump CE Java SDK to 4.0.1

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: #4235 failed to apply on top of branch "release-1.16":

Applying: Bump CE Java SDK to 4.0.1
Using index info to reconstruct a base tree...
M	data-plane/THIRD-PARTY.txt
M	data-plane/pom.xml
Falling back to patching base and 3-way merge...
Auto-merging data-plane/pom.xml
CONFLICT (content): Merge conflict in data-plane/pom.xml
Auto-merging data-plane/THIRD-PARTY.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Bump CE Java SDK to 4.0.1

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #4236

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

matzew pushed a commit to matzew/eventing-kafka-broker that referenced this pull request Feb 4, 2025
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Feb 4, 2025
* Bump CE Java SDK to 4.0.1 (knative-extensions#4235)

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Quarkys 3.13 (knative-extensions#4243)

Signed-off-by: Matthias Wessendorf <[email protected]>

* Align w/ Quarkus 3.15 and friends
Try with 3.15.2

We change the mircometer-prometheus client dependency, because the simpleclient is backwards compatible to the old APIs.
While vertx-micrometer 4.5.10 is still on the 1.12 APIs, we do inherit the 1.13 micrometer APIs via the Quarkus BOM...
And hence we really need the simpleclient, we are using that, to avoid clash

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants