Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus 3.15.2 #4240

Closed
wants to merge 4 commits into from
Closed

Quarkus 3.15.2 #4240

wants to merge 4 commits into from

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jan 30, 2025

Generally we want the latest of 3.15.x (see #4240). but there is an issue. Hence going w/ 3.15.2

Proposed Changes

  • go w/ Quarks 3.15.2 and friends
bump vertx dependency to 4.5.10

Docs

Update breaking (micrometer/vertx) API calls

Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link

knative-prow bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.32%. Comparing base (574618f) to head (2b9f175).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4240      +/-   ##
==========================================
- Coverage   45.33%   45.32%   -0.02%     
==========================================
  Files         290      290              
  Lines       19869    19869              
==========================================
- Hits         9008     9005       -3     
- Misses      10149    10151       +2     
- Partials      712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Contributor Author

matzew commented Jan 31, 2025

/retest

Copy link

knative-prow bot commented Jan 31, 2025

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
channel-integration-tests-sasl-plain_eventing-kafka-broker_main 2b9f175 link true /test channel-integration-tests-sasl-plain
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main 2b9f175 link true /test channel-reconciler-tests-sasl-ssl
channel-integration-tests-sasl-ssl_eventing-kafka-broker_main 2b9f175 link true /test channel-integration-tests-sasl-ssl
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main 2b9f175 link true /test channel-reconciler-tests-sasl-plain
channel-reconciler-tests-ssl_eventing-kafka-broker_main 2b9f175 link true /test channel-reconciler-tests-ssl
channel-integration-tests-ssl_eventing-kafka-broker_main 2b9f175 link true /test channel-integration-tests-ssl
integration-tests_eventing-kafka-broker_main 2b9f175 link true /test integration-tests
reconciler-tests-keda_eventing-kafka-broker_main 2b9f175 link true /test reconciler-tests-keda
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 2b9f175 link true /test reconciler-tests-namespaced-broker
reconciler-tests_eventing-kafka-broker_main 2b9f175 link true /test reconciler-tests
upgrade-tests_eventing-kafka-broker_main 2b9f175 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2025
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Contributor Author

matzew commented Feb 4, 2025

/close

replaced by #4245

@knative-prow knative-prow bot closed this Feb 4, 2025
Copy link

knative-prow bot commented Feb 4, 2025

@matzew: Closed this PR.

In response to this:

/close

replaced by #4245

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants