Skip to content

Commit

Permalink
decreasing dispatcher and adapter resource cpu requests for edge case…
Browse files Browse the repository at this point in the history
…s where the system does not have heavy traffic (#816)

Co-authored-by: gabriel <[email protected]>
  • Loading branch information
knative-prow-robot and gabo1208 authored Jun 14, 2022
1 parent 76b09bb commit 299234f
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pkg/reconciler/broker/resources/dispatcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func MakeDispatcherDeployment(args *DispatcherArgs) *appsv1.Deployment {
// more info in this issue: https://github.com/knative-sandbox/eventing-rabbitmq/issues/703
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("300m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("64Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("4000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/broker/resources/dispatcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func TestMakeDispatcherDeployment(t *testing.T) {
Image: image,
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("300m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("64Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("4000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/broker/resources/ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func MakeIngressDeployment(args *IngressArgs) *appsv1.Deployment {
// more info in this issue: https://github.com/knative-sandbox/eventing-rabbitmq/issues/703
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("150m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("32Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("1000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/broker/resources/ingress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func TestMakeIngressDeployment(t *testing.T) {
Name: "ingress",
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("150m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("32Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("1000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/source/resources/receive_adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func MakeReceiveAdapter(args *ReceiveAdapterArgs) *v1.Deployment {
// more info in this issue: https://github.com/knative-sandbox/eventing-rabbitmq/issues/703
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("300m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("64Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("4000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/source/resources/receive_adapter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func TestMakeReceiveAdapter(t *testing.T) {
ImagePullPolicy: "IfNotPresent",
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("300m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("64Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("4000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/trigger/resources/dispatcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func MakeDispatcherDeployment(args *DispatcherArgs) *appsv1.Deployment {
// more info in this issue: https://github.com/knative-sandbox/eventing-rabbitmq/issues/703
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("300m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("64Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("4000m"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/trigger/resources/dispatcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func deployment(opts ...func(*appsv1.Deployment)) *appsv1.Deployment {
Image: image,
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("300m"),
corev1.ResourceCPU: resource.MustParse("50m"),
corev1.ResourceMemory: resource.MustParse("64Mi")},
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("4000m"),
Expand Down

0 comments on commit 299234f

Please sign in to comment.