Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated client-pkg in favor of knative.dev/client/pkg #365

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

dsimansk
Copy link
Contributor

Changes

  • Fix deprecated client-pkg in favor of knative.dev/client/pkg

Fixing tech debt.

/cc @skonto

@knative-prow knative-prow bot requested a review from skonto January 23, 2025 16:10
Copy link

knative-prow bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 72.78%. Comparing base (aeb1784) to head (c39dd38).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/e2e/common.go 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   78.03%   72.78%   -5.25%     
==========================================
  Files          27       28       +1     
  Lines        1525     1635     +110     
==========================================
  Hits         1190     1190              
- Misses        272      382     +110     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor Author

/override "codecov/patch"
/override "codecov/project"

Copy link

knative-prow bot commented Jan 23, 2025

@dsimansk: Overrode contexts on behalf of dsimansk: codecov/patch, codecov/project

In response to this:

/override "codecov/patch"
/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk dsimansk added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@knative-prow knative-prow bot merged commit 5b39563 into knative-extensions:main Jan 23, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant