Fixed reconcile running on all KIngress after ksvc deletion

[ryutoyasugi]

Why

I found Reconcile running on all KIngress after ksvc was removed.
The same problem has been reported. #941

Changes

Fixed conditions under which resyncConflicts are executed.
https://github.com/knative-extensions/net-kourier/blob/cbd0d74/pkg/reconciler/ingress/ingress.go#L135

Related PR

#502, #486

[knative-prow]

Hi @ryutoyasugi. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbd0d74) 80.81% compared to head (b6b5c9d) 80.81%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          18       18           
  Lines        1392     1392           
=======================================
  Hits         1125     1125           
  Misses        213      213           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[skonto]

Given that:

func (c *Condition) GetReason() string {
	if c == nil {
		return ""
	}
	return c.Reason
}

Ingresses that have condition(LBReady) that is not nil, do have Reason "" and match all the reconciled ones correct?

[ryutoyasugi]

Yes, for successfully working ingresses, the condition(LBReady) is not nil and the Reason is empty.

[skonto]

/ok-to-test

[skonto]

I tested it locally with conflicting dms, stamping it.
/lgtm

[skonto]

/cherry-pick release-1.12
/approve

[knative-prow-robot]

@skonto: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryutoyasugi, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@skonto: new pull request created: #1170

In response to this:

/cherry-pick release-1.12
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.