Fix coverage settings

[skonto]

Changes

Fixes the coverage ci settings as discussed here.

/hold for #761

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skonto
To complete the pull request process, please assign xtreme-sameer-vohra after the PR has been reviewed.
You can assign the PR to them by writing /assign @xtreme-sameer-vohra in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

Welcome @skonto! It looks like this is your first PR to knative-sandbox/net-kourier 🎉

[knative-prow-robot]

Hi @skonto. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nak3]

Hmm...
The .codecov.yaml is used by github action https://github.com/knative-sandbox/net-kourier/blob/main/.github/workflows/knative-go-test.yaml#L66-L70 but is it true that pull-knative-sandbox-net-kourier-go-coveragealso use it?
Please note that the go-coverage's code is here https://github.com/knative/test-infra/tree/main/tools/coverage/.

Also, if this is proper fix, we need to apply all repos like https://github.com/knative/serving/blob/main/.codecov.yaml#L18 https://github.com/knative/eventing/blob/main/.codecov.yaml#L18 https://github.com/knative/pkg/blob/main/.codecov.yaml#L20.
So if you don't mind, could you bring up your fix against serving or pkg repo? I would like net-kourier repo to follow the parent repos.

[nak3]

Would like to understand #802 (comment)

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skonto
To complete the pull request process, please assign xtreme-sameer-vohra after the PR has been reviewed.
You can assign the PR to them by writing /assign @xtreme-sameer-vohra in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skonto]

@nak3 already merged in pkg knative/pkg#2471. Will do for Serving too. Not sure how this file is being picked up by prow, I could dig into it.

[nak3]

@nak3 already merged in pkg knative/pkg#2471.

I mean why the change - "**/zz_generated.deepcopy.go" # Ignore generated files. needs only for this repository? You didn't change it in pkg repo.

Not sure how this file is being picked up by prow, I could dig into it.

Yes, please. I still cannot believe that the prow uses .codecov.yaml.

[skonto]

@nak3 I did ignore whole folders in pkg so no need for the pattern.I dont have access to see the actual reports as the ones failing in #824

[nak3]

I don't think you ignore whole folders in pkg repo - for example https://github.com/knative/pkg/blob/main/apis/zz_generated.deepcopy.go.

And again, I still cannot believe that the prow uses .codecov.yaml...

[skonto]

Ok will try find what prow does as stated before but no promise.

[skonto]

Given my comment here we can close this PR. The file is indeed used by codecov, but it seems the coverage tooling has changed. The report here has nothing to do with the previous failed report here that led to this PR.

[nak3]

Well... You tried to fix this prow issue #761 (comment), right?
You started seeing different coverage.

[skonto]

@nak3

Please note that the go-coverage's code is here https://github.com/knative/test-infra/tree/main/tools/coverage/.

Coverage tool has been deprecated and removed while this PR was open. Check PR here ten days ago. The fix here had the assumption that we still used prow.

Explanation here: knative/test-infra#3155 (comment)

Prow job is not used anymore, codecov is.

Even though the coverage tool has been removed, we should remove the job from here: https://github.com/chizhg/test-infra/blob/f198796824fe7e913af7009f8bacd2d294220684/config/prow/testgrid/testgrid.yaml#L766
as the knative operator project has done: knative/test-infra#3156 a couple of weeks ago.