Added the new custom resources RolloutOrchestrator&StagePodAutoscaler for rolling upgrade #12

houshengbo · 2023-10-25T13:52:58Z

Changes

/kind

Fixes #13

Release Note

Docs

knative-prow · 2023-10-25T13:53:00Z

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note
Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-10-25T13:57:22Z

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (d6ef1e3) 21.31% compared to head (4be398b) 72.16%.
Report is 1 commits behind head on main.

❗ Current head 4be398b differs from pull request most recent head 6f80d02. Consider uploading reports for the commit 6f80d02 to get more accurate results

Files	Patch %	Lines
...g/apis/serving/v1/rolloutorchestrator_lifecycle.go	58.18%	23 Missing ⚠️
pkg/apis/serving/v1/rolloutorchestrator_types.go	33.33%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
+ Coverage   21.31%   72.16%   +50.85%     
===========================================
  Files           9        5        -4     
  Lines          61       97       +36     
===========================================
+ Hits           13       70       +57     
+ Misses         48       27       -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuzisun · 2023-10-28T20:14:37Z

pkg/apis/serving/v1/stagepodautoscaler_types.go

+type StagePodAutoscalerSpec struct {
+	// MinScale sets the lower bound for the number of the replicas.
+	// +optional
+	MinScale *int32 `json:"minScale,omitempty"`
+
+	// MaxScale sets the upper bound for the number of the replicas.
+	// +optional
+	MaxScale *int32 `json:"maxScale,omitempty"`
+}


Do we need this ? min/max scale can be got from the service or revision spec.

Not quite, the service and revision can only determine the ultimate min and max scale. The min and max scale here are for the current stage.

The min/max for each stage shouldn't be different as it is specified by user right?

They both change from stage to stage, in order to control the number of replicas.

Then it is not min/max ? Min/max should stay the same for each revision as this is the user input, from what I understand you update this number for each stage and eventually the number of replica can reach to min or max. Is that correct?

yuzisun · 2023-10-28T20:16:05Z

pkg/apis/serving/v1/stagepodautoscaler_types.go

+	DesiredScale *int32 `json:"desiredScale,omitempty"`
+
+	// ActualScale shows the actual number of replicas for the revision.
+	ActualScale *int32 `json:"actualScale,omitempty"`


These fields already exist on KPA autoscaler, can we update KPA status object instead?

Knative already create too many child custom resources , let's try not creating new ones unless we really need to.

This is the good point, but I really need this ActualScale in the status of this stagepodautoscaler.
This reason is as below:

This change in podautoscaler is only able to kick-off the reconcile loop of the revision. However, I need any change in podautoscaler to kick off the reconcile loop of the service orchestrator.
So I have to use podautoscaler to kick off the reconcile loop of stagepodautoscaler, since they share the same name. And with the change of ActualScale in the stagepodautoscaler to kick off the reconcile loop of the service orchestrator.

yuzisun · 2023-10-28T20:31:33Z

pkg/apis/serving/v1/serviceorchestrator_types.go

+	// TargetRevisions holds the information of the target revisions in the final stage.
+	// These entries will always contain RevisionName references.
+	// +optional
+	TargetRevisions []TargetRevision `json:"targetRevisions,omitempty"`
+
+	// InitialRevisions holds the information of the initial revisions in the initial stage.
+	// These entries will always contain RevisionName references.
+	// +optional
+	InitialRevisions []TargetRevision `json:"initialRevisions,omitempty"`


Can you help document an example how InitialRevision and TargetRevision are used?

Yes.

When there is no revision available, the InitialRevisions will be empty, and the TargetRevisions will be empty.

When there is an existing revision, and we create a new revision, InitialRevisions will be set to the existing revision with 100% traffic, and TargetRevisions will be set to the new revision with 100% traffic.

During the transition from the old to new revision, TargetRevisions and InitialRevisions remain the same as TargetRevisions pointing to the new revision of the ultimate goal, and InitialRevision pointing to the old revision of the initial status.

When the transition is over, InitialRevisions and TargetRevisions will be reset to empty.

ok, good to leave this as comments on the defined fields.

yuzisun · 2023-10-28T20:32:12Z

pkg/apis/serving/v1/serviceorchestrator_types.go

+
+// ServiceOrchestratorSpec holds the desired state of the ServiceOrchestrator (from the client).
+type ServiceOrchestratorSpec struct {
+	StageTarget `json:",inline"`


stages in transition indicates that these should be status fields?

There are fields service orchestrator will set for each stage. They are specs.

yuzisun · 2023-11-04T13:51:45Z

config/core/300-resources/serviceorchestrator.yaml

+spec:
+  group: serving.knative.dev
+  names:
+    kind: ServiceOrchestrator


I think a better name is RolloutOrchestrator ?

yuzisun · 2023-11-16T19:28:27Z

/lgtm
/approve

knative-prow · 2023-11-16T19:28:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [houshengbo,yuzisun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot requested review from sukumargaonkar and upodroid October 25, 2023 13:53

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2023

houshengbo force-pushed the add-service-autoscaler branch 2 times, most recently from 42012aa to ff06df9 Compare October 26, 2023 20:53

yuzisun reviewed Oct 28, 2023

View reviewed changes

houshengbo force-pushed the add-service-autoscaler branch from a2ead19 to 8dec861 Compare November 3, 2023 15:02

yuzisun reviewed Nov 4, 2023

View reviewed changes

houshengbo added 11 commits November 9, 2023 21:11

Added controller and autoscaler into this extension

d250666

Mofidy the go.mod

8560af9

Removed sample APIs and added stagepodautoscaler&serviceorchestrator

d8d081d

Added the CM serviceorchestrator to configure the over-consumption-ratio

7846e01

Updated the dependencies

057cd4c

Rename the receicers

120e086

Change the go.mod

e85041a

Updated the fields and comments

397d547

Added test cases

8a1082c

Rename the vars and constants

c1e8c06

Update the deps

2e3cb2f

houshengbo force-pushed the add-service-autoscaler branch from 8dec861 to 2e3cb2f Compare November 10, 2023 03:46

Rename ServiceOrchestrator into RolloutOrchestrator

25f82fd

houshengbo changed the title ~~Added the new custom resources ServiceOrchestrator&StagePodAutoscaler for rolling upgrade~~ Added the new custom resources RolloutOrchestrator&StagePodAutoscaler for rolling upgrade Nov 10, 2023

houshengbo force-pushed the add-service-autoscaler branch from 23b6243 to ca778d9 Compare November 10, 2023 22:50

Install the CRDs in the github action

eb88382

houshengbo force-pushed the add-service-autoscaler branch from ca778d9 to eb88382 Compare November 10, 2023 23:03

houshengbo added 5 commits November 10, 2023 19:42

Rename the files

beca7fd

Add the comments to InitialRevisions and TargetRevisions

628084d

Add the kodata for autoscaler

56eb87b

Update the zz_generated.deepcopy.go

8b1cd08

Rename the min and max scale for stagePodAutoScaler

6f80d02

houshengbo force-pushed the add-service-autoscaler branch from 4be398b to 6f80d02 Compare November 15, 2023 00:53

knative-prow bot assigned yuzisun Nov 16, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023

knative-prow bot merged commit f14dd6d into knative-extensions:main Nov 16, 2023
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the new custom resources RolloutOrchestrator&StagePodAutoscaler for rolling upgrade #12

Added the new custom resources RolloutOrchestrator&StagePodAutoscaler for rolling upgrade #12

houshengbo commented Oct 25, 2023 •

edited

Loading

knative-prow bot commented Oct 25, 2023

Changes

codecov bot commented Oct 25, 2023 •

edited

Loading

yuzisun Oct 28, 2023

houshengbo Oct 30, 2023

yuzisun Nov 4, 2023

houshengbo Nov 11, 2023

yuzisun Nov 11, 2023

houshengbo Nov 13, 2023

yuzisun Oct 28, 2023

yuzisun Oct 28, 2023

houshengbo Oct 30, 2023 •

edited

Loading

yuzisun Oct 28, 2023

houshengbo Oct 30, 2023

yuzisun Nov 4, 2023

yuzisun Oct 28, 2023

houshengbo Oct 30, 2023

yuzisun Nov 4, 2023

houshengbo Nov 11, 2023

yuzisun commented Nov 16, 2023

knative-prow bot commented Nov 16, 2023

Added the new custom resources RolloutOrchestrator&StagePodAutoscaler for rolling upgrade #12

Added the new custom resources RolloutOrchestrator&StagePodAutoscaler for rolling upgrade #12

Conversation

houshengbo commented Oct 25, 2023 • edited Loading

Changes

knative-prow bot commented Oct 25, 2023

Changes

codecov bot commented Oct 25, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houshengbo Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yuzisun commented Nov 16, 2023

knative-prow bot commented Nov 16, 2023

houshengbo commented Oct 25, 2023 •

edited

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading

houshengbo Oct 30, 2023 •

edited

Loading