Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Make the branch configurable for Serving #180

Merged

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented May 17, 2024

No description provided.

Copy link

knative-prow bot commented May 17, 2024

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested a review from alexagriffith May 17, 2024 15:19
Copy link

knative-prow bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from yuzisun May 17, 2024 15:19
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2024
@houshengbo houshengbo force-pushed the release-1.13-configure branch from 5fcb88c to 0dab298 Compare May 17, 2024 15:20
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.83%. Comparing base (ddf75b0) to head (cab2468).
Report is 6 commits behind head on release-1.13.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13     #180      +/-   ##
================================================
- Coverage         49.42%   48.83%   -0.60%     
================================================
  Files                23       25       +2     
  Lines              2280     1894     -386     
================================================
- Hits               1127      925     -202     
+ Misses             1109      924     -185     
- Partials             44       45       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@knative-prow knative-prow bot merged commit 536b505 into knative-extensions:release-1.13 May 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant