Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Refactored the functions cleanUpSPAs and resetObsoleteSPAs #188

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #186

@knative-prow knative-prow bot requested review from alexagriffith and yuzisun May 21, 2024 00:28
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2024
@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link

knative-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 48.12%. Comparing base (ddf75b0) to head (0d9ad86).
Report is 8 commits behind head on release-1.13.

Files Patch % Lines
...onciler/rolloutorchestrator/rolloutorchestrator.go 0.00% 38 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13     #188      +/-   ##
================================================
- Coverage         49.42%   48.12%   -1.31%     
================================================
  Files                23       25       +2     
  Lines              2280     1943     -337     
================================================
- Hits               1127      935     -192     
+ Misses             1109      961     -148     
- Partials             44       47       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houshengbo houshengbo merged commit 0e210c5 into knative-extensions:release-1.13 May 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants