Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the status before returning nil in reconcile #192

Merged
merged 3 commits into from
May 24, 2024

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented May 23, 2024

Fixes: #193

  • This func prevents old revision going back, when the new revision fails to spin up.
  • Updated the status before returning nil in the reconcile of ro.

Copy link

knative-prow bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 47.72%. Comparing base (7ac0552) to head (16d00e5).
Report is 1 commits behind head on main.

Files Patch % Lines
...onciler/rolloutorchestrator/strategies/strategy.go 0.00% 16 Missing ⚠️
...onciler/rolloutorchestrator/rolloutorchestrator.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   48.12%   47.72%   -0.40%     
==========================================
  Files          25       25              
  Lines        1943     1959      +16     
==========================================
  Hits          935      935              
- Misses        961      977      +16     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@houshengbo houshengbo force-pushed the revert-obs-removal branch from 65ee8fe to 71ccdf1 Compare May 23, 2024 18:25
@houshengbo houshengbo changed the title Removed the call of resetObsoleteSPAs tentatively Updated the status before returning nil in reconcile May 23, 2024
@houshengbo houshengbo force-pushed the revert-obs-removal branch from b26383c to 8562705 Compare May 24, 2024 00:56
@houshengbo houshengbo force-pushed the revert-obs-removal branch from 8562705 to 16d00e5 Compare May 24, 2024 01:13
@houshengbo
Copy link
Contributor Author

/cherry-pick release-1.13

@knative-prow-robot
Copy link

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@houshengbo
Copy link
Contributor Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@knative-prow knative-prow bot merged commit 56f6c01 into knative-extensions:main May 24, 2024
26 checks passed
@knative-prow-robot
Copy link

@houshengbo: new pull request created: #195

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link

@houshengbo: new pull request created: #196

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewObservedGenFailure will pop up once upgrading the images of serving progressive rollout
2 participants