Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang to 1.23 #236

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Bump golang to 1.23 #236

merged 1 commit into from
Dec 2, 2024

Conversation

dsimansk
Copy link
Contributor

Changes

  • Bump golang to 1.23

@upodroid @dprotaso @knative/knative-release-leads I wonder if we should jump on Go 1.23 before the next release cycle. What's your preference?
I'll follow-up with knative/infra PR for prow images if we agree to proceed.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@dsimansk
Copy link
Contributor Author

/hold for folks to chime in.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@dprotaso
Copy link
Member

I wouldn't bump this late in the release cycle.

@dsimansk
Copy link
Contributor Author

I wouldn't bump this late in the release cycle.

Make sense, we started the release with initial batch of repos cut. This can wait & hold until the Knative 1.16.

@dsimansk
Copy link
Contributor Author

dsimansk commented Nov 5, 2024

@dprotaso @upodroid @cardil reviving the PR after release.

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 10, 2024
@evankanderson
Copy link
Member

/lgtm

@dsimansk
Copy link
Contributor Author

/approve

@matejvasek
Copy link
Contributor

PTAL @cardil

@cardil
Copy link
Contributor

cardil commented Dec 2, 2024

I think we can bump it. It should resolve issues we see in knative/func#2604

/lgtm
/approve

Copy link

knative-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cardil,dsimansk,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@knative-prow knative-prow bot merged commit 1617247 into knative:main Dec 2, 2024
7 checks passed
@cardil
Copy link
Contributor

cardil commented Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants