Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to supply-chain details rather than including inline. #6199

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

evankanderson
Copy link
Member

Followup to #6193

Proposed Changes

  • Reduces the text on the YAML/operator install pages, and makes clear that signature verification is an optional step, and not a required prerequisite

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2025
Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f3d957
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/678d12cb13ed5a000836f48c
😎 Deploy Preview https://deploy-preview-6199--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I like this, IMO definitely makes the install instructions clearer

/hold in case @pierDipi or @dprotaso have opinions (since this changes the install docs for Serving/Eventing)

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2025
Copy link

knative-prow bot commented Jan 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Cali0707,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

/cc @dprotaso @pierDipi

@knative-prow knative-prow bot requested review from dprotaso and pierDipi January 19, 2025 22:45
@dprotaso
Copy link
Member

/hold cancel

thanks for the follow up Evan

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2025
@knative-prow knative-prow bot merged commit a4a09b3 into knative:main Jan 19, 2025
19 checks passed
@dprotaso
Copy link
Member

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6200

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants