Skip to content

Commit

Permalink
Add deprecation warnings for v1b2 (#7454)
Browse files Browse the repository at this point in the history
* Change structure of crd versions for PingSource

Signed-off-by: Matthias Wessendorf <[email protected]>

* 💄 Add deprecation warning to v1beta2 resource version

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Matthias Wessendorf <[email protected]>
  • Loading branch information
matzew authored Nov 15, 2023
1 parent 3162518 commit a9320dc
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions config/core/resources/pingsource.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ spec:
group: sources.knative.dev
versions:
- &version
name: v1beta2
name: v1
served: true
storage: false
storage: true
subresources:
status: {}
schema:
Expand Down Expand Up @@ -214,9 +214,14 @@ spec:
type: string
jsonPath: ".status.conditions[?(@.type=='Ready')].reason"
- <<: *version
name: v1
name: v1beta2
served: true
storage: true
storage: false
# This indicates the v1beta2 version of the custom resource is deprecated.
# API requests to this version receive a warning header in the server response.
deprecated: true
# This overrides the default warning returned to API clients making v1beta2 API requests.
deprecationWarning: "sources.knative.dev/v1beta2 PingSource is deprecated; see https://knative.dev/docs/eventing/sources/ping-source/ for instructions to migrate to sources.knative.dev/v1 PingSource"
# v1 schema is identical to the v1beta2 schema
names:
categories:
Expand Down

0 comments on commit a9320dc

Please sign in to comment.