-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes #7355
Conversation
…nProviders cache to 5 minuets Signed-off-by: Harshvir Potpose <[email protected]>
Welcome @akagami-harsh! It looks like this is your first PR to knative/eventing 🎉 |
Hi @akagami-harsh. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @akagami-harsh |
Co-authored-by: Pierangelo Di Pilato <[email protected]>
please add the hackotberfest tag |
/ok-to-test |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7355 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 252 252
Lines 13727 13822 +95
=======================================
+ Hits 10548 10622 +74
- Misses 2652 2669 +17
- Partials 527 531 +4
☔ View full report in Codecov by Sentry. |
Thanks for your contribution @akagami-harsh 🎉 /retitle Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akagami-harsh can you update the comment on line 76 to indicate that we are now using a buffer of 5min, not 30 seconds?
done |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @akagami-harsh 🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akagami-harsh, Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ers cache to 5 minuets
Fixes #7351
Proposed Changes
Pre-review Checklist
Release Note
Docs