-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EventType Source Attribute Required #7382
Make EventType Source Attribute Required #7382
Conversation
Signed-off-by: karthikmurali60 <[email protected]>
Signed-off-by: karthikmurali60 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karthikmurali60 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @karthikmurali60. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Make EventType Source Attribute Required |
Hi, we are defining a new API for the EventType. A POC is herE: This is the feature track: In that doc we do discuss that attrs like |
This Pull Request is stale because it has been open for 90 days with |
Fixes #7314
Proposed Changes
Pre-review Checklist
Release Note
Docs