Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EventType Source Attribute Required #7382

Closed

Conversation

karthikmurali60
Copy link
Contributor

Fixes #7314

Proposed Changes

  • Make source attribute required

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karthikmurali60
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

Hi @karthikmurali60. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from aliok and odacremolbap October 19, 2023 15:28
@Cali0707
Copy link
Member

/cc @pierDipi @matzew
Does an API chnage from optional -> required need an api version bump?

@knative-prow knative-prow bot requested review from matzew and pierDipi October 19, 2023 16:26
@Cali0707
Copy link
Member

/retitle Make EventType Source Attribute Required

@knative-prow knative-prow bot changed the title Make source required Make EventType Source Attribute Required Oct 19, 2023
@matzew
Copy link
Member

matzew commented Oct 26, 2023

Hi, we are defining a new API for the EventType. A POC is herE:
#7313

This is the feature track:
https://docs.google.com/document/d/1hxCpQMI_qCy2CsHEv0nits4t65DExkizgg3KLvD4z2s/edit?resourcekey=0-ts4WNm_tlNYWuo9eWe1stA#heading=h.n8a530nnrb

In that doc we do discuss that attrs like source are required.

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2024
@github-actions github-actions bot closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventtype has SOURCE attr as optional
3 participants