-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the rekt test for pingsource with broker as sink #7416
Adding the rekt test for pingsource with broker as sink #7416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7416 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 253 253
Lines 13916 13916
=======================================
Hits 10680 10680
Misses 2702 2702
Partials 534 534 ☔ View full report in Codecov by Sentry. |
LGTM overall, a few comments to clean up the unused code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #6932
Proposed Changes
Pre-review Checklist
Release Note
Docs