Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the rekt test for pingsource with broker as sink #7416

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Oct 27, 2023

Fixes #6932

Proposed Changes

  • A rekt-based e2e test for PingSource TLS support when using Broker as sink

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Added a rekt-based e2e test for PingSource TLS support when using Broker as sink

Docs

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0684dbe) 76.74% compared to head (4bbe5b9) 76.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7416   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files         253      253           
  Lines       13916    13916           
=======================================
  Hits        10680    10680           
  Misses       2702     2702           
  Partials      534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Oct 27, 2023

/cc @pierDipi @creydr @Cali0707

test/rekt/features/pingsource/features.go Outdated Show resolved Hide resolved
test/rekt/features/pingsource/features.go Outdated Show resolved Hide resolved
@Leo6Leo Leo6Leo requested a review from pierDipi October 30, 2023 19:16
@pierDipi
Copy link
Member

LGTM overall, a few comments to clean up the unused code

@Leo6Leo Leo6Leo requested a review from pierDipi October 31, 2023 14:26
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link

knative-prow bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@knative-prow knative-prow bot merged commit 650d965 into knative:main Nov 2, 2023
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing TLS: Test PingSource with Broker as sink
3 participants