Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provisioning of sequences reply and steps audience #7501

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Dec 8, 2023

Fixes #7489
Fixes #7490

Proposed Changes

  • 🐛 Add audience field to sequence reply
  • 🐛 Fix sequence reconciler to set audience of reply and steps
  • 🎁 Add e2e tests for sequence flow

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

@creydr creydr requested a review from mgencur December 8, 2023 11:00
@knative-prow knative-prow bot requested review from aslom and evankanderson December 8, 2023 11:00
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e1fbeb) 76.12% compared to head (4bcaafc) 76.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7501   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files         260      260           
  Lines       14467    14467           
=======================================
  Hits        11013    11013           
  Misses       2888     2888           
  Partials      566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr changed the title Fix sequence reply and steps audience Fix provisioning of sequences reply and steps audience Dec 8, 2023
@creydr
Copy link
Member Author

creydr commented Dec 8, 2023

/cc @mgencur

@mgencur
Copy link
Contributor

mgencur commented Dec 8, 2023

Nice!

@creydr creydr requested a review from pierDipi December 8, 2023 13:19
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
Copy link

knative-prow bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@creydr creydr force-pushed the fix-sequence-reply-audience branch from 4abc923 to bdd2307 Compare December 12, 2023 11:26
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@creydr creydr requested a review from matzew December 12, 2023 13:30
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023
@knative-prow knative-prow bot merged commit 0b45ad8 into knative:main Dec 12, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OIDC e2e test for Sequence Provide Sequence Reply with audience field for OIDC authentication
4 participants