Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventPolicy resource for rekt tests #8010

Merged

Conversation

creydr
Copy link
Member

@creydr creydr commented Jun 17, 2024

Fixes #8009

Adding helpers for rekt test to work with EventPolicies.

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2024
@knative-prow knative-prow bot requested review from evankanderson and mgencur June 17, 2024 12:23
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@creydr creydr force-pushed the add-eventpolicy-resource-for-rekt-tests branch from 7e58801 to fcf2563 Compare June 17, 2024 12:29
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (e298f32) to head (05c817b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8010   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files         362      362           
  Lines       16714    16714           
=======================================
  Hits        11323    11323           
  Misses       4695     4695           
  Partials      696      696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr changed the title Add EventPolicy resource for rekt tests [WIP] Add EventPolicy resource for rekt tests Jun 17, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@creydr creydr force-pushed the add-eventpolicy-resource-for-rekt-tests branch from 7cdf2ac to 1683138 Compare June 17, 2024 13:20
@creydr creydr changed the title [WIP] Add EventPolicy resource for rekt tests Add EventPolicy resource for rekt tests Jun 17, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@creydr
Copy link
Member Author

creydr commented Jun 18, 2024

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi June 18, 2024 09:45
@creydr
Copy link
Member Author

creydr commented Jun 18, 2024

/cc @converge

@knative-prow knative-prow bot requested a review from converge June 18, 2024 12:03
@Cali0707 Cali0707 self-requested a review June 19, 2024 17:54
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small thing I wasn't sure about

test/rekt/resources/eventpolicy/eventpolicy.go Outdated Show resolved Hide resolved
@creydr creydr requested a review from Cali0707 June 20, 2024 07:15
@creydr
Copy link
Member Author

creydr commented Jun 24, 2024

@Cali0707 can you recheck?

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link

knative-prow bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7253b36 into knative:main Jun 24, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rekt test resource for EventPolicy
2 participants