Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint errors #8089

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 9, 2024

Recently I've been seeing a lot of linter errors in files that were not edited in the relevant PR (for example, see the files with comments from reviewdog in https://github.com/knative/eventing/pull/8087/files)

Proposed Changes

  • Fix the linter errors

Signed-off-by: Calum Murray <[email protected]>
@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2024
@knative-prow knative-prow bot requested review from matzew and mgencur July 9, 2024 18:08
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

/cc @Leo6Leo @yijie-04 @matzew

@knative-prow knative-prow bot requested review from Leo6Leo and yijie-04 July 9, 2024 18:08
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.80%. Comparing base (71d7e5e) to head (8c13de0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8089      +/-   ##
==========================================
- Coverage   67.85%   67.80%   -0.06%     
==========================================
  Files         367      367              
  Lines       17354    17373      +19     
==========================================
+ Hits        11775    11779       +4     
- Misses       4844     4859      +15     
  Partials      735      735              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 9, 2024

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

I think there are more

Yeah I only covered the ones that showed up on the earlier PR before, I didn't realize that reviewdog only reported a few of the problems. I should have all the licenses in cmd, test, hack, and pkg correct now (at least for go files). I'll keep an eye on this and add more fixes as needed...

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 9, 2024

For reference, the changeset was generated by running:

find pkg -type f -name "*.go" -exec sed -i 's/\(    \)\(http:\/\/www.apache.org\/licenses\/LICENSE-2.0\)/\t\2/' {} + 

Signed-off-by: Calum Murray <[email protected]>
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link

knative-prow bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9ea1d54 into knative:main Jul 10, 2024
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants