-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix lint errors #8089
chore: fix lint errors #8089
Conversation
Signed-off-by: Calum Murray <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8089 +/- ##
==========================================
- Coverage 67.85% 67.80% -0.06%
==========================================
Files 367 367
Lines 17354 17373 +19
==========================================
+ Hits 11775 11779 +4
- Misses 4844 4859 +15
Partials 735 735 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Calum Murray <[email protected]>
Yeah I only covered the ones that showed up on the earlier PR before, I didn't realize that reviewdog only reported a few of the problems. I should have all the licenses in |
For reference, the changeset was generated by running: find pkg -type f -name "*.go" -exec sed -i 's/\( \)\(http:\/\/www.apache.org\/licenses\/LICENSE-2.0\)/\t\2/' {} + |
Signed-off-by: Calum Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Recently I've been seeing a lot of linter errors in files that were not edited in the relevant PR (for example, see the files with comments from reviewdog in https://github.com/knative/eventing/pull/8087/files)
Proposed Changes