Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eventtype conversion sets all required attributes for new version #8099

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Cali0707
Copy link
Member

Fixes a problem where any v1beta2 eventtype converted to a v1beta3 eventtype would have some attributes missing that would make it an invalid v1beta3 eventtype.

Proposed Changes

  • Always set all 4 required attributes
  • Omit the value for the required attribute if it can't be determined from the v1beta2 resource

@knative-prow knative-prow bot requested review from Leo6Leo and lionelvillard July 11, 2024 15:37
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2024
@Cali0707
Copy link
Member Author

/cc @matzew @Leo6Leo

@knative-prow knative-prow bot requested a review from matzew July 11, 2024 15:37
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (bb2e0a3) to head (8eb8852).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8099      +/-   ##
==========================================
+ Coverage   67.82%   67.85%   +0.02%     
==========================================
  Files         367      367              
  Lines       17411    17427      +16     
==========================================
+ Hits        11809    11825      +16     
  Misses       4864     4864              
  Partials      738      738              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
Copy link

knative-prow bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5d6c780 into knative:main Jul 12, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants