Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event lineage builder should accept client interfaces #8402

Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Jan 8, 2025

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@knative-prow knative-prow bot requested review from creydr and matzew January 8, 2025 12:52
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
Copy link

knative-prow bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.12%. Comparing base (bb6c53c) to head (4375ad7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/graph/constructor.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8402   +/-   ##
=======================================
  Coverage   64.12%   64.12%           
=======================================
  Files         388      388           
  Lines       23339    23339           
=======================================
  Hits        14965    14965           
  Misses       7579     7579           
  Partials      795      795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aliok
Copy link
Member Author

aliok commented Jan 8, 2025

/test unit-tests
wtf

@pierDipi
Copy link
Member

pierDipi commented Jan 8, 2025

/test reconciler-tests

@knative-prow knative-prow bot merged commit 134c4c0 into knative:main Jan 8, 2025
36 checks passed
@aliok aliok deleted the 2025-01-08-lineage-to-accept-interfaces branch January 8, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants