Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test improvements remove deprecates avoid nils, bump go version 1.20.x #2032

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🧹 removing deprecated method calls on test
  • 🧹 avoiding nils on http calls for test
  • 🧹 improving match condition for func run test

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 18, 2023
@knative-prow knative-prow bot requested review from gauron99 and maximilien October 18, 2023 01:54
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (788f18c) 56.33% compared to head (bbf1a78) 62.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   56.33%   62.57%   +6.24%     
==========================================
  Files         105      106       +1     
  Lines       13691    13693       +2     
==========================================
+ Hits         7713     8569     +856     
+ Misses       5197     4248     -949     
- Partials      781      876      +95     
Flag Coverage Δ
e2e-test 36.46% <ø> (ø)
e2e-test-oncluster-runtime 26.79% <ø> (?)
e2e-test-runtime-go 25.59% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.64% <ø> (?)
e2e-test-runtime-typescript 26.71% <ø> (?)
integration-tests 51.47% <ø> (?)
unit-tests-macos-latest 48.21% <ø> (?)
unit-tests-ubuntu-latest 49.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@jrangelramos jrangelramos changed the title test improvements remove deprecates avoid nils test improvements remove deprecates avoid nils, bump go version 1.20.x Oct 18, 2023
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3641bfe into knative:main Oct 18, 2023
@jrangelramos jrangelramos deleted the fix-nil-host-test branch October 18, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants