-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding e2e test for func subscribe command #2110
Conversation
e879b1b
to
9b9ac87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
+ Coverage 62.78% 63.13% +0.35%
==========================================
Files 108 108
Lines 13868 13868
==========================================
+ Hits 8707 8756 +49
+ Misses 4318 4250 -68
- Partials 843 862 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9b9ac87
to
a653e69
Compare
new test execution canbe found here https://github.com/knative/func/actions/runs/7466686343/job/20318596719?pr=2110#step:7:195 |
a653e69
to
ba60cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ReToCode would you please override the "Integration Test (ubuntu-latest)" failure? |
/override "Integration Test (ubuntu-latest)" |
@ReToCode: Overrode contexts on behalf of ReToCode: Integration Test (ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
/kind enhancement