Update golangci-lint #2606
Update golangci-lint #2606
Conversation
Signed-off-by: Matej Vašek <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XS
matejvasek
requested review from
dsimansk,
gauron99 and
lkingland
and removed request for
nainaz and
vyasgun
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
==========================================
+ Coverage 64.13% 65.41% +1.28%
==========================================
Files 130 130
Lines 15516 15516
==========================================
+ Hits 9951 10150 +199
+ Misses 4625 4389 -236
- Partials 940 977 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -303,7 +303,7 @@ func mergeEnvs(envs []fn.Env, envToUpdate *util.OrderedMap, envToRemove []string | |||
|
|
|||
| errMsg := fn.ValidateEnvs(envs) | |||
| if len(errMsg) > 0 { | |||
| return []fn.Env{}, 0, fmt.Errorf(strings.Join(errMsg, "\n")) | |||
| return []fn.Env{}, 0, fmt.Errorf("error(s) while validating envs: %s", strings.Join(errMsg, "\n")) | |||
There was a problem hiding this comment.
what does the error(s) mean?
There was a problem hiding this comment.
There may be one or more.
There was a problem hiding this comment.
IMO something in the realm of covering plural form if present: e.g. 1 error vs. 2 errors
|
/lgtm |
Changes