Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock #2630

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix deadlock #2630

merged 2 commits into from
Dec 20, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for nainaz December 20, 2024 01:59
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (1122bf7) to head (a55da35).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2630      +/-   ##
==========================================
+ Coverage   64.13%   65.44%   +1.30%     
==========================================
  Files         130      130              
  Lines       15518    15518              
==========================================
+ Hits         9953    10155     +202     
+ Misses       4625     4387     -238     
- Partials      940      976      +36     
Flag Coverage Δ
e2e-test 35.83% <ø> (-0.03%) ⬇️
e2e-test-oncluster 32.82% <ø> (-0.01%) ⬇️
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.46% <ø> (?)
e2e-test-runtime-node 25.84% <ø> (?)
e2e-test-runtime-python 25.84% <ø> (?)
e2e-test-runtime-quarkus 25.99% <ø> (?)
e2e-test-runtime-rust 24.94% <ø> (?)
e2e-test-runtime-springboot 24.98% <ø> (?)
e2e-test-runtime-typescript 25.95% <ø> (?)
integration-tests 51.95% <ø> (+2.27%) ⬆️
unit-tests 50.93% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matej Vašek <[email protected]>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
Copy link

knative-prow bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8475f86 into knative:main Dec 20, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants