Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps to match latest Knative versions #2652

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

dsimansk
Copy link
Contributor

Changes

  • Update deps to match latest Knative versions
  • Update openshift-pipelines/pipelines-as-code to latest version v0.31.0
    • This change enabled drop of client-go replace, but added replace for different library it requires. Anyway, still a bit clean wrt/ k8s.io deps.

/cc @matejvasek

/kind

Fixes #

Release Note

Update go modules to match Knative versions

@knative-prow knative-prow bot requested a review from matejvasek January 16, 2025 13:55
Copy link

knative-prow bot commented Jan 16, 2025

@dsimansk: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Update deps to match latest Knative versions
  • Update openshift-pipelines/pipelines-as-code to latest version v0.31.0
  • This change enabled drop of client-go replace, but added replace for different library it requires. Anyway, still a bit clean wrt/ k8s.io deps.

/cc @matejvasek

/kind

Fixes #

Release Note

Update go modules to match Knative versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2025
go.mod Show resolved Hide resolved
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
Copy link

knative-prow bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (f734f82) to head (454d468).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
+ Coverage   64.13%   65.44%   +1.30%     
==========================================
  Files         130      130              
  Lines       15518    15518              
==========================================
+ Hits         9953    10156     +203     
+ Misses       4625     4386     -239     
- Partials      940      976      +36     
Flag Coverage Δ
e2e-test 35.81% <ø> (-0.05%) ⬇️
e2e-test-oncluster 32.82% <ø> (ø)
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.44% <ø> (?)
e2e-test-runtime-node 25.84% <ø> (?)
e2e-test-runtime-python 25.84% <ø> (?)
e2e-test-runtime-quarkus 25.99% <ø> (?)
e2e-test-runtime-rust 24.92% <ø> (?)
e2e-test-runtime-springboot 24.98% <ø> (?)
e2e-test-runtime-typescript 25.95% <ø> (?)
integration-tests 51.98% <ø> (+2.32%) ⬆️
unit-tests 50.95% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 09e2eef into knative:main Jan 16, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants