Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move non-oncluster test to e2e #2659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🧹 Moving non on-cluster test to e2e

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 17, 2025
Copy link

knative-prow bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@knative-prow knative-prow bot requested review from dsimansk and rhuss January 17, 2025 14:07
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.21%. Comparing base (02b331d) to head (94ef7ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2659      +/-   ##
==========================================
- Coverage   64.13%   62.21%   -1.93%     
==========================================
  Files         130      128       -2     
  Lines       15518    15509       -9     
==========================================
- Hits         9953     9649     -304     
- Misses       4625     4909     +284     
- Partials      940      951      +11     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 28.66% <ø> (-4.14%) ⬇️
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.46% <ø> (?)
e2e-test-runtime-node 25.84% <ø> (?)
e2e-test-runtime-python 25.84% <ø> (?)
e2e-test-runtime-quarkus 25.99% <ø> (?)
e2e-test-runtime-rust 24.94% <ø> (?)
e2e-test-runtime-springboot 24.98% <ø> (?)
e2e-test-runtime-typescript 25.95% <ø> (?)
integration-tests 51.98% <ø> (+2.30%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos jrangelramos force-pushed the jrangelramos/move-non-cluster-test branch from b5ca91d to 94ef7ad Compare January 17, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant