[WIP] [DNM] From scratch #2671

matejvasek · 2025-01-23T18:26:46Z

Changes

/kind

Fixes #

Release Note

Docs

Detect also if pod did not exited prematurely. Signed-off-by: Matej Vašek <[email protected]>

knative-prow · 2025-01-23T18:26:49Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

knative-prow · 2025-01-23T18:26:49Z

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note
Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow · 2025-01-23T18:26:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/func-util/main.go

codecov · 2025-01-23T18:33:49Z

Codecov Report

Attention: Patch coverage is 52.43902% with 39 lines in your changes missing coverage. Please review.

Project coverage is 65.36%. Comparing base (20a173a) to head (4cf012c).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/tar/tar.go	55.84%	24 Missing and 10 partials ⚠️
pkg/k8s/dialer.go	0.00%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
+ Coverage   64.16%   65.36%   +1.19%     
==========================================
  Files         130      131       +1     
  Lines       15519    15601      +82     
==========================================
+ Hits         9958    10197     +239     
+ Misses       4622     4416     -206     
- Partials      939      988      +49

Flag	Coverage Δ
e2e-test	`35.80% <0.00%> (-0.06%)`	⬇️
e2e-test-oncluster	`34.20% <0.00%> (+1.32%)`	⬆️
e2e-test-oncluster-runtime	`28.64% <0.00%> (?)`
e2e-test-runtime-go	`26.43% <0.00%> (?)`
e2e-test-runtime-node	`25.83% <0.00%> (?)`
e2e-test-runtime-python	`25.84% <0.00%> (?)`
e2e-test-runtime-quarkus	`25.98% <0.00%> (?)`
e2e-test-runtime-rust	`24.91% <0.00%> (?)`
e2e-test-runtime-springboot	`24.97% <0.00%> (?)`
e2e-test-runtime-typescript	`25.94% <0.00%> (?)`
integration-tests	`52.02% <52.43%> (+2.34%)`	⬆️
unit-tests	`50.96% <52.43%> (?)`
unit-tests-macos-latest	`?`
unit-tests-ubuntu-latest	`?`
unit-tests-windows-latest	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/func-util/main.go

pkg/tar/tar.go

This commit removes depencency on sh and tar binaries by implementing the logic in our func-util binary. Signed-off-by: Matej Vašek <[email protected]>

pkg/tar/tar.go

Signed-off-by: Matej Vašek <[email protected]>

Fixed pod readiness check

079db29

Detect also if pod did not exited prematurely. Signed-off-by: Matej Vašek <[email protected]>

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2025

knative-prow bot requested review from jrangelramos and rhuss January 23, 2025 18:26

knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

cmd/func-util/main.go Fixed Show fixed Hide fixed

cmd/func-util/main.go Fixed Show fixed Hide fixed

cmd/func-util/main.go Fixed Show fixed Hide fixed

matejvasek removed the request for review from rhuss January 23, 2025 18:37

matejvasek force-pushed the from-scratch branch 2 times, most recently from 74f1ab8 to 2f528db Compare January 23, 2025 19:12

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025

matejvasek force-pushed the from-scratch branch 3 times, most recently from 39ae38a to 3b48ccc Compare January 24, 2025 02:07

github-advanced-security bot found potential problems Jan 24, 2025

View reviewed changes

cmd/func-util/main.go Fixed Show fixed Hide fixed

cmd/func-util/main.go Fixed Show fixed Hide fixed

cmd/func-util/main.go Fixed Show fixed Hide fixed

matejvasek force-pushed the from-scratch branch from 3b48ccc to 4c3d604 Compare January 24, 2025 19:31

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025

github-advanced-security bot found potential problems Jan 24, 2025

View reviewed changes

pkg/tar/tar.go Fixed Show fixed Hide fixed

pkg/tar/tar.go Fixed Show fixed Hide fixed

pkg/tar/tar.go Fixed Show fixed Hide fixed

matejvasek force-pushed the from-scratch branch 3 times, most recently from 163dd3b to b9bd1cb Compare January 24, 2025 20:17

github-advanced-security bot found potential problems Jan 24, 2025

View reviewed changes

pkg/tar/tar.go Fixed Show fixed Hide fixed

matejvasek force-pushed the from-scratch branch 2 times, most recently from a5bf6a3 to d9e8190 Compare January 24, 2025 21:19

matejvasek force-pushed the from-scratch branch 2 times, most recently from 6ace6cc to 215d976 Compare January 24, 2025 23:33

Removed dependency on sh/tar from alpine image

586c6b9

This commit removes depencency on sh and tar binaries by implementing the logic in our func-util binary. Signed-off-by: Matej Vašek <[email protected]>

matejvasek force-pushed the from-scratch branch from 215d976 to 586c6b9 Compare January 27, 2025 15:13

github-advanced-security bot found potential problems Jan 27, 2025

View reviewed changes

pkg/tar/tar.go Dismissed Show dismissed Hide dismissed

pkg/tar/tar.go Dismissed Show dismissed Hide dismissed

matejvasek force-pushed the from-scratch branch from d218ef8 to 0d558eb Compare January 27, 2025 19:35

matejvasek added 2 commits January 27, 2025 20:37

WIP

7aaac3e

Signed-off-by: Matej Vašek <[email protected]>

WIP

4549789

Signed-off-by: Matej Vašek <[email protected]>

matejvasek force-pushed the from-scratch branch from 0d558eb to 4549789 Compare January 27, 2025 19:55

WIP

4cf012c

Signed-off-by: Matej Vašek <[email protected]>

matejvasek closed this Jan 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] [DNM] From scratch #2671

[WIP] [DNM] From scratch #2671

matejvasek commented Jan 23, 2025

knative-prow bot commented Jan 23, 2025

knative-prow bot commented Jan 23, 2025

Changes

knative-prow bot commented Jan 23, 2025

codecov bot commented Jan 23, 2025 •

edited

Loading

[WIP] [DNM] From scratch #2671

[WIP] [DNM] From scratch #2671

Conversation

matejvasek commented Jan 23, 2025

Changes

knative-prow bot commented Jan 23, 2025

knative-prow bot commented Jan 23, 2025

Changes

knative-prow bot commented Jan 23, 2025

codecov bot commented Jan 23, 2025 • edited Loading

Codecov Report

codecov bot commented Jan 23, 2025 •

edited

Loading