-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on signing and attestation for serving #288
Conversation
Can you update the codegen please? I'll comment on the security audit PR with more info on this. |
Updated, sorry I missed your comment earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@evankanderson: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which issue(s) this PR fixes:
Fixes #287
I think there's something in the environment overrides that caused
.base.yaml
to not apply for Serving, but this seems to have fixed it. I assumed we'd want any further patch releases on the existing lines to get signatures + attestations, so I updates the existing releases as well.