Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix istio no-mesh build command #450

Merged
merged 1 commit into from
May 30, 2024

Conversation

ReToCode
Copy link
Member

Which issue(s) this PR fixes:
Fixes knative/serving#15274

What this PR does, why we need it:

  • Fixes istio build config (no-mesh build should have --no-mesh)

@knative-prow knative-prow bot requested review from mgencur and upodroid May 30, 2024 06:02
@ReToCode
Copy link
Member Author

/assign @dprotaso
/assign @skonto

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
Copy link

knative-prow bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@knative-prow knative-prow bot merged commit ccbb38b into knative:main May 30, 2024
17 checks passed
Copy link

knative-prow bot commented May 30, 2024

@ReToCode: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:
Fixes knative/serving#15274

What this PR does, why we need it:

  • Fixes istio build config (no-mesh build should have --no-mesh)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Istio prow job is running with a wrong flag (mesh vs. no-mesh)
3 participants