Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back serving 1.15 release for a patch #582

Merged
merged 2 commits into from
Jan 22, 2025
Merged

bring back serving 1.15 release for a patch #582

merged 2 commits into from
Jan 22, 2025

Conversation

dprotaso
Copy link
Member

we wanted to kick off a 1.15 release but prow automation deleted it when 1.17 release came out

@knative-prow knative-prow bot requested review from cardil and upodroid January 22, 2025 15:55
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

cc @houshengbo

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
@houshengbo
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@knative-prow knative-prow bot merged commit 6c8a788 into knative:main Jan 22, 2025
17 checks passed
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 22, 2025

@dprotaso: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-release-1.15.gen.yaml using file prow/jobs/generated/knative/serving-release-1.15.gen.yaml

In response to this:

we wanted to kick off a 1.15 release but prow automation deleted it when 1.17 release came out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso dprotaso deleted the serving-1-15 branch January 22, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprotaso @houshengbo