fix closure variable in filtered factory #2884
Conversation
knative-prow
bot
added
do-not-merge/hold
knative-prow
bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
+ Coverage 81.80% 81.85% +0.05%
==========================================
Files 167 167
Lines 10231 10231
==========================================
+ Hits 8369 8375 +6
+ Misses 1614 1610 -4
+ Partials 248 246 -2 ☔ View full report in Codecov by Sentry. |
|
/unhold @dprotaso PTAL. |
knative-prow
bot
removed
the
do-not-merge/hold
|
LGTM should not these generators have some unit tests? |
|
/approve
Ideally. We should also be replacing this generated code with generics. But I think when we do that we should consider refactoring/tweaking some of the controller framework we built. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.11 |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dprotaso: new pull request created: #2885 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dprotaso: new pull request created: #2886 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
selectorinwithInformerFactorywithin the for loop to avoid issues in func()/kind bug
Fixes #2883
/hold verifying this in Serving