-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linter config and address lint warnings/failures #3068
Conversation
dprotaso
commented
Jun 24, 2024
•
edited
Loading
edited
- fix whitespace linter
- fix usestdlibvars
- fix staticheck
- ignore spancheck warning
- fix linter perfsprint
- fix nolintlint feedback
- fix nilerr lint checks
- fix misspell
- fix mirror lint
- fix intrange linter
- fix gofumpt linter
- fix gosec linter - ignore warning since default min tls version is 1.3
- fix gocritic linter
- fix whitespace
- fix fatcontext linter
- fix errorlint
- fix errname linter
- fix copyloopvar (go1.22) linter
- fix bodyclose linter
- update linter config
- add script to format code
Skipping CI for Draft Pull Request. |
/test all |
/hold this depends on #3067 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3068 +/- ##
==========================================
+ Coverage 78.42% 78.44% +0.02%
==========================================
Files 191 191
Lines 8939 8936 -3
==========================================
Hits 7010 7010
+ Misses 1666 1664 -2
+ Partials 263 262 -1 ☔ View full report in Codecov by Sentry. |
flake TestMetricsExport/OpenCensus /retest |
/hold cancel |
Ok - this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, evankanderson, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |