-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop use of code-generator/generate-groups.sh #3136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3136 +/- ##
=======================================
Coverage 78.27% 78.27%
=======================================
Files 191 191
Lines 11192 11192
=======================================
Hits 8761 8761
Misses 2164 2164
Partials 267 267 ☔ View full report in Codecov by Sentry. |
|
I think, we need to keep There's an error later in the log:
|
The wrong script at first, we are getting @dprotaso sorry to step in. I was on the verge to cut the release branch in We can either do GOFLAGS clean or stop sourcing library.sh, at least the latter worked in the PR. Cleaned up my changes to this one: d5cf972 PTAL @dprotaso or we can proceed with your preferred way to fix it. |
3d28a44
to
d5cf972
Compare
We don't need this in the release - it's just a clean up |
it's weird - i run the prow image locally and running the presubmit tests pass haha |
Indeed, same on my side. I can't reproduce it locally. |
There's some issue with "new" kube generator scripts in the Prow jobs. I've noticed the following errors:
|
72fe43b
to
b773405
Compare
ok build passed - I forgot to push a change 🫨 |
/retest |
1 similar comment
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
generate-groups.sh is deprecated
/assign @skonto