Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop use of code-generator/generate-groups.sh #3136

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

dprotaso
Copy link
Member

generate-groups.sh is deprecated

/assign @skonto

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release labels Jan 16, 2025
@knative-prow knative-prow bot requested review from mgencur, pierDipi and skonto January 16, 2025 23:37
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.27%. Comparing base (0c2a238) to head (fcbbecf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3136   +/-   ##
=======================================
  Coverage   78.27%   78.27%           
=======================================
  Files         191      191           
  Lines       11192    11192           
=======================================
  Hits         8761     8761           
  Misses       2164     2164           
  Partials      267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Jan 17, 2025

--- FAIL: go-licenses failed the license check

@dsimansk
Copy link
Contributor

--- FAIL: go-licenses failed the license check

I think, we need to keep export GOFLAGS=-mod= in the update script. I've added a quick commit, let's see.

There's an error later in the log:

2025/01/16 23:40:02 Getting artifacts dir from prow
test/genclient/pub/injection/client/client.go:27:2: cannot find module providing package knative.dev/pkg/test/genclient/pub/clientset/versioned: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
test/genclient/pub/injection/client/fake/fake.go:28:2: cannot find module providing package knative.dev/pkg/test/genclient/pub/clientset/versioned/fake: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
test/genclient/pub/injection/informers/factory/factory.go:27:2: cannot find module providing package knative.dev/pkg/test/genclient/pub/informers/externalversions: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
test/genclient/pub/injection/informers/pub/v1alpha1/bar/bar.go:27:2: cannot find module providing package knative.dev/pkg/test/genclient/pub/informers/externalversions/pub/v1alpha1: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
test/genclient/pub/injection/reconciler/pub/v1alpha1/bar/controller.go:40:2: cannot find module providing package knative.dev/pkg/test/genclient/pub/clientset/versioned/scheme: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
test/genclient/pub/injection/reconciler/pub/v1alpha1/bar/reconciler.go:42:2: cannot find module providing package knative.dev/pkg/test/genclient/pub/listers/pub/v1alpha1: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)
Command '__build_test_runner_for_module' failed in module /home/prow/go/src/knative.dev/pkg: 1

@dsimansk
Copy link
Contributor

dsimansk commented Jan 17, 2025

The wrong script at first, we are getting GOFLAGS=-mod=vendor leaked from library.sh or just the course of execution in the builds tests.

@dprotaso sorry to step in. I was on the verge to cut the release branch in pkg when noticed this PR.

We can either do GOFLAGS clean or stop sourcing library.sh, at least the latter worked in the PR.

Cleaned up my changes to this one: d5cf972

PTAL @dprotaso or we can proceed with your preferred way to fix it.

@dsimansk dsimansk force-pushed the drop-generate-groups branch from 3d28a44 to d5cf972 Compare January 17, 2025 11:53
@dprotaso
Copy link
Member Author

We don't need this in the release - it's just a clean up

@dprotaso
Copy link
Member Author

dprotaso commented Jan 17, 2025

it's weird - i run the prow image locally and running the presubmit tests pass haha

@dsimansk
Copy link
Contributor

it's weird - i run the prow image locally and running the presubmit tests pass haha

Indeed, same on my side. I can't reproduce it locally.

@dsimansk
Copy link
Contributor

There's some issue with "new" kube generator scripts in the Prow jobs. I've noticed the following errors:

grep: /home/prow/go/src/knative.dev/pkg/test/genclient/clientset: No such file or directory

@dprotaso dprotaso force-pushed the drop-generate-groups branch from 72fe43b to b773405 Compare January 17, 2025 16:28
@dprotaso
Copy link
Member Author

ok build passed - I forgot to push a change 🫨

@dprotaso
Copy link
Member Author

/retest

1 similar comment
@dprotaso
Copy link
Member Author

/retest

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
Copy link

knative-prow bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a37a847 into knative:main Jan 17, 2025
39 checks passed
@dprotaso dprotaso deleted the drop-generate-groups branch January 17, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants