[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/autoscaler/metrics/serving_api.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

Process completed with exit code 1.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: application_deployment_automation/code/deploy_apps.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: createCluster.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: createKindCluster.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: setup_scripts/configure_containerd.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: setup_scripts/configure_kubectl.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: setup_scripts/elk_deploy.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: setup_scripts/observability.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.

Process completed with exit code 1.

Please run goimports. diff --git a/pkg/activator/handler/concurrency_reporter.go b/pkg/activator/handler/concurrency_reporter.go index 71f8470..b1dae58 100644 --- a/pkg/activator/handler/concurrency_reporter.go +++ b/pkg/activator/handler/concurrency_reporter.go @@ -18,11 +18,12 @@ package handler import ( "context" + "fmt" "math" "net/http" "sync" "time" - "fmt" + "go.uber.org/atomic" "go.uber.org/zap" "k8s.io/apimachinery/pkg/types"

Please run goimports. diff --git a/pkg/activator/handler/handler.go b/pkg/activator/handler/handler.go index d590eba..1352f75 100644 --- a/pkg/activator/handler/handler.go +++ b/pkg/activator/handler/handler.go @@ -19,12 +19,13 @@ package handler import ( "context" "errors" + "fmt" "net/http" "net/http/httputil" "strconv" "strings" "time" - "fmt" + "go.opencensus.io/plugin/ochttp" "go.opencensus.io/trace" "go.uber.org/zap"

Please run goimports. diff --git a/pkg/http/proxy.go b/pkg/http/proxy.go index 0891f9a..7c1683c 100644 --- a/pkg/http/proxy.go +++ b/pkg/http/proxy.go @@ -20,6 +20,7 @@ import ( "net/http" "net/http/httputil" "time" + "go.uber.org/zap" netheader "knative.dev/networking/pkg/http/header"

Please run goimports. diff --git a/pkg/queue/request_metric.go b/pkg/queue/request_metric.go index 248bf22..2e78ab9 100644 --- a/pkg/queue/request_metric.go +++ b/pkg/queue/request_metric.go @@ -18,9 +18,9 @@ package queue import ( "context" + "fmt" "net/http" "time" - "fmt" "go.opencensus.io/stats" "go.opencensus.io/stats/view"

Process completed with exit code 1.

[trailing whitespace] reported by reviewdog 🐶 else: Raw Output: application_deployment_automation/code/app_deployment.py:43: else:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/app_deployment.py:54:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/app_deployment.py:89:

[trailing whitespace] reported by reviewdog 🐶 ## We specify that we now wish to execute Raw Output: application_deployment_automation/code/app_yaml_templates.py:17: ## We specify that we now wish to execute

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/check_alloc.py:21:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/check_alloc.py:30:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/check_alloc.py:131:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/check_alloc.py:135:

[trailing whitespace] reported by reviewdog 🐶 Raw Output: application_deployment_automation/code/create_app_deployment_yaml.py:40:

reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835

G501: Blocklisted import crypto/md5: weak cryptographic primitive (gosec)

G401: Use of weak cryptographic primitive (gosec)

var-naming: don't use underscores in Go names; func parameter map_logger should be mapLogger (revive)

var-naming: don't use underscores in Go names; func parameter forecast_window should be forecastWindow (revive)

var-naming: don't use underscores in Go names; var json_data should be jsonData (revive)

var-naming: don't use underscores in Go names; func parameter forecasted_result should be forecastedResult (revive)

var-naming: don't use underscores in Go names; func fill_per_instance_map should be fillPerInstanceMap (revive)

var-naming: don't use underscores in Go names; var per_instance_map should be perInstanceMap (revive)

var-naming: don't use underscores in Go names; struct field forecasted_result should be forecastedResult (revive)

var-naming: don't use underscores in Go names; struct field forecasted_pods should be forecastedPods (revive)

[github.com/client9/misspell] reported by reviewdog 🐶 "successfuly" is a misspelling of "successfully" Raw Output: knative_post_processing/code/get_es_result.py:99:17: "successfuly" is a misspelling of "successfully"

[github.com/client9/misspell] reported by reviewdog 🐶 "occurence" is a misspelling of "occurrence" Raw Output: knative_post_processing/code/request_post_processing.py:190:23: "occurence" is a misspelling of "occurrence"

[github.com/client9/misspell] reported by reviewdog 🐶 "maintainance" is a misspelling of "maintenance" Raw Output: pkg/autoscaler/metrics/collector.go:62:205: "maintainance" is a misspelling of "maintenance"

[github.com/client9/misspell] reported by reviewdog 🐶 "maintainance" is a misspelling of "maintenance" Raw Output: pkg/autoscaler/metrics/collector.go:63:263: "maintainance" is a misspelling of "maintenance"

[github.com/client9/misspell] reported by reviewdog 🐶 "maintainance" is a misspelling of "maintenance" Raw Output: pkg/autoscaler/metrics/collector.go:63:282: "maintainance" is a misspelling of "maintenance"

[github.com/client9/misspell] reported by reviewdog 🐶 "maintainance" is a misspelling of "maintenance" Raw Output: pkg/autoscaler/metrics/collector.go:99:1: "maintainance" is a misspelling of "maintenance"

[github.com/client9/misspell] reported by reviewdog 🐶 "arbitary" is a misspelling of "arbitrary" Raw Output: setup_scripts/values_fb.yaml:425:39: "arbitary" is a misspelling of "arbitrary"

Process completed with exit code 1.

[woke] reported by reviewdog 🐶 [error] `Guys` may be insensitive, use `folks`, `people`, `you all`, `y'all`, `yinz` instead Raw Output: knative_post_processing/code/testing.ipynb:14000:28804: [error] `Guys` may be insensitive, use `folks`, `people`, `you all`, `y'all`, `yinz` instead

[woke] reported by reviewdog 🐶 [error] `dummy` may be insensitive, use `placeholder`, `sample` instead Raw Output: setup_scripts/values_kb.yaml:107:10: [error] `dummy` may be insensitive, use `placeholder`, `sample` instead

[woke] reported by reviewdog 🐶 [error] `dummy` may be insensitive, use `placeholder`, `sample` instead Raw Output: setup_scripts/values_kb.yaml:112:10: [error] `dummy` may be insensitive, use `placeholder`, `sample` instead

[woke] reported by reviewdog 🐶 [warning] `whitelist` may be insensitive, use `allowlist`, `inclusion list` instead Raw Output: setup_scripts/values_es.yaml:308:75: [warning] `whitelist` may be insensitive, use `allowlist`, `inclusion list` instead

Process completed with exit code 1.

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: application_deployment_automation/code/app_deployment.py:96: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: application_deployment_automation/code/app_yaml_templates.py:79: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: application_deployment_automation/code/controller.py:23: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: application_deployment_automation/code/synthetic_pattern_generator.py:35: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: application_deployment_automation/data/deployment_template.yaml:29: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: application_deployment_automation/data/misc/workload_configs_default.json:12: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: config/core/deployments/flask-forecaster.yaml:145: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: config/core/deployments/flask-forecaster2.yaml:145: Missing newline

[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: createCluster.sh:58: Missing newline

reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/