[wip] Private Service doesn't need a cluster IP #10146
knative-style.yaml
on: pull_request
style
/
changes
8s
style
/
...
/
Auto-format and Check
19s
style
/
...
/
Lint
1m 57s
style
/
...
/
Do Not Submit
6s
style
/
...
/
shell
0s
style
/
...
/
yaml
0s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
12 errors and 4 warnings
style / Golang / Boilerplate Check (go):
pkg/networking/util.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/networking/util.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (go):
pkg/networking/util_test.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/networking/util_test.go:1: missing boilerplate:
/*
Copyright 2024 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
style / Golang / Boilerplate Check (sh):
hack/boilerplate/add-boilerplate.sh#L1
[Bash headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
hack/boilerplate/add-boilerplate.sh:1: missing boilerplate:
#!/usr/bin/env bash
# Copyright 2024 The Knative Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
|
style / Golang / Boilerplate Check (sh):
test/upload-test-images.sh#L2
[Bash headers] reported by reviewdog 🐶
found mismatched boilerplate lines:
Raw Output:
test/upload-test-images.sh:2: found mismatched boilerplate lines:
{[]string}[0]:
-: ""
+: "#"
{[]string}[7]:
-: "# http://www.apache.org/licenses/LICENSE-2.0"
+: "# https://www.apache.org/licenses/LICENSE-2.0"
|
style / Golang / Lint:
DEVELOPMENT.md#L161
[trailing whitespace] reported by reviewdog 🐶
- By default, `ko` will build container images for the architecture of your local machine,
Raw Output:
DEVELOPMENT.md:161:- By default, `ko` will build container images for the architecture of your local machine,
|
style / Golang / Lint:
DEVELOPMENT.md#L162
[trailing whitespace] reported by reviewdog 🐶
but if you need to build images for a different platform (OS and architecture),
Raw Output:
DEVELOPMENT.md:162: but if you need to build images for a different platform (OS and architecture),
|
style / Golang / Lint:
DEVELOPMENT.md#L163
[trailing whitespace] reported by reviewdog 🐶
you can provide `--platform` flag as follows:
Raw Output:
DEVELOPMENT.md:163: you can provide `--platform` flag as follows:
|
style / Golang / Lint:
docs/encryption/knative-encryption.md#L25
[trailing whitespace] reported by reviewdog 🐶
* These certificates are either [provided manually](https://knative.dev/docs/serving/using-a-tls-cert/) or by using an implementation to the [Knative Certificate abstraction](https://github.com/knative/networking/blob/main/pkg/apis/networking/v1alpha1/certificate_types.go#L34). Currently, we support the [net-certmanager](https://github.com/knative-extensions/net-certmanager) implementation.
Raw Output:
docs/encryption/knative-encryption.md:25:* These certificates are either [provided manually](https://knative.dev/docs/serving/using-a-tls-cert/) or by using an implementation to the [Knative Certificate abstraction](https://github.com/knative/networking/blob/main/pkg/apis/networking/v1alpha1/certificate_types.go#L34). Currently, we support the [net-certmanager](https://github.com/knative-extensions/net-certmanager) implementation.
|
style / Golang / Lint:
docs/scaling/images/scale-from-0.png#L232
[EOF Newline] reported by reviewdog 🐶
Missing newline
Raw Output:
docs/scaling/images/scale-from-0.png:232: Missing newline
|
style / Golang / Lint:
docs/scaling/images/scale-to-0.png#L209
[EOF Newline] reported by reviewdog 🐶
Missing newline
Raw Output:
docs/scaling/images/scale-to-0.png:209: Missing newline
|
style / Golang / Lint:
docs/scaling/images/scale-up-down.png#L200
[EOF Newline] reported by reviewdog 🐶
Missing newline
Raw Output:
docs/scaling/images/scale-up-down.png:200: Missing newline
|
style / Golang / Lint:
docs/spec/images/object_model.png#L55
[EOF Newline] reported by reviewdog 🐶
Missing newline
Raw Output:
docs/spec/images/object_model.png:55: Missing newline
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|