change private K8s service to be a headless service (#15170)

* change private K8s service to be a headless service * use clusteripnone constant
knative · Jul 10, 2024 · 6760aa6 · 6760aa6
1 parent 2156812
commit 6760aa6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/reconciler/serverlessservice/resources/services.go b/pkg/reconciler/serverlessservice/resources/services.go
@@ -188,7 +188,8 @@ func MakePrivateService(sks *v1alpha1.ServerlessService, selector map[string]str
 				Port:       targetPort(sks).IntVal,
 				TargetPort: targetPort(sks),
 			}},
-			Selector: selector,
+			Selector:  selector,
+			ClusterIP: corev1.ClusterIPNone,
 		},
 	}
 }
diff --git a/pkg/reconciler/serverlessservice/resources/services_test.go b/pkg/reconciler/serverlessservice/resources/services_test.go
@@ -133,6 +133,7 @@ func privateSvcMod(s *corev1.Service) {
 			"app": "sadness",
 		}
 	}
+	s.Spec.ClusterIP = corev1.ClusterIPNone
 	s.Spec.Ports = append(s.Spec.Ports,
 		[]corev1.ServicePort{{
 			Name:       servingv1.AutoscalingQueueMetricsPortName,
@@ -470,6 +471,7 @@ func TestMakePrivateService(t *testing.T) {
 			s.Labels["ava"] = "adore"
 			s.Labels[networking.SKSLabelKey] = "dream-tonight-cherub-rock-mayonnaise-hummer-disarm-rocket-soma-quiet"
 			s.Annotations = map[string]string{"cherub": "rock"}
+			s.Spec.ClusterIP = corev1.ClusterIPNone
 		}, privateSvcMod, func(s *corev1.Service) {
 			// And now patch port to be http2.
 			s.Spec.Ports[0] = corev1.ServicePort{