• ❌ - login: @subha-91 . The commit (5048628) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Welcome @subhasree91! It looks like this is your first PR to knative/serving 🎉

Hi @subhasree91. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: subhasree91
Once this PR has been reviewed and has the lgtm label, please assign salaboy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hey thanks for the PR - I've been wondering about this for a while.

Is there a reason why we wouldn't just hardcode the # to zero or maybe one? Odd that the godoc isn't clear exactly on the semantics there

Since revisions track history I'm wondering if we should set this to 0

From the K8s docs

More specifically, setting this field to zero means that all old ReplicaSets with 0 replicas will be cleaned up. In this case, a new Deployment rollout cannot be undone, since its revision history is cleaned up.

Since revisions track history I'm wondering if we should set this to 0

If we don't do any deployment rollbacks we should be on the safe side.

If we don't do any deployment rollbacks we should be on the safe side.

We don't. So I say we just set it to zero.

@subhasree91 are you interested in making the necessary updates?

@subhasree91 moved to a different team in our org and won't progress this. I addressed the review comments here: #15698

fyi @dprotaso @skonto

/close

@SaschaSchwarze0: You can't close an active issue/PR unless you authored it or you are a collaborator.

Since I moved to a different team, I won't progress with the issue.

fyi @dprotaso @skonto

/close

@subhasree91: Closed this PR.