-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure deployments to have no own revisionHistoryLimit #15698
Configure deployments to have no own revisionHistoryLimit #15698
Conversation
Hi @SaschaSchwarze0. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The revision history limit of a deployment are its replicasets. As Knative has its own concept of revisions and the way a deployment looks like for revision is defined by the revision, there is no reason to maintain a history of replicasets. Multiple replicasets can exist if Knative configuration is updated (config-deployment) or if Knative itself is updated (and the queue-proxy image changes). Having no revisionHistoryLimit on the Deployment saves a lot of space in the Kubernetes database. Co-authored-by: Subhasree Das <[email protected]> Signed-off-by: Sascha Schwarze <[email protected]>
c408385
to
280b048
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15698 +/- ##
==========================================
+ Coverage 80.76% 80.83% +0.06%
==========================================
Files 222 222
Lines 18025 18026 +1
==========================================
+ Hits 14558 14571 +13
+ Misses 3094 3084 -10
+ Partials 373 371 -2 ☔ View full report in Codecov by Sentry. |
/lgtm @SaschaSchwarze0 thanks for the quick turn around |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Proposed Changes
Continuation of #15640
The revision history limit of a deployment are its replicasets. As Knative has its own concept of revisions and the way a deployment looks like for revision is defined by the revision, there is no reason to maintain a history of replicasets. Multiple replicasets can exist if Knative configuration is updated (config-deployment) or if Knative itself is updated (and the queue-proxy image changes). Having no revisionHistoryLimit on the Deployment saves a lot of space in the Kubernetes database.
This PR changes the deployments that Knative creates to always have revisionHistoryLimit set to 0.
Release Note