Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serving-internal docs about Knative encryption support #13662

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

ReToCode
Copy link
Member

Related to #11906

Proposed Changes

  • Add serving-internal docs about Knative encryption support
  • Add a visualization

@knative-prow knative-prow bot requested review from julz and psschwei January 31, 2023 14:15
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2023
@ReToCode
Copy link
Member Author

As discussed yesterday in Security WG.

/assign @evankanderson

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 86.22% // Head: 86.25% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c8c9ec8) compared to base (3b8d6cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13662      +/-   ##
==========================================
+ Coverage   86.22%   86.25%   +0.03%     
==========================================
  Files         197      197              
  Lines       14783    14783              
==========================================
+ Hits        12746    12751       +5     
+ Misses       1735     1731       -4     
+ Partials      302      301       -1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️
pkg/autoscaler/statserver/server.go 77.37% <0.00%> (+1.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@knative-prow knative-prow bot merged commit 53b3c92 into knative:main Feb 1, 2023
@ReToCode ReToCode deleted the internal-encryption-docs branch February 2, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants