Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #14626

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 8b2a470...67dcf8f:
  > 67dcf8f upgrade to latest dependencies (# 628)

@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from 7fd7656 to 7c69a4f Compare November 16, 2023 11:05
@knative-prow knative-prow bot requested a review from a team November 16, 2023 11:05
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/networking labels Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7561386) 86.02% compared to head (951fe75) 86.01%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14626      +/-   ##
==========================================
- Coverage   86.02%   86.01%   -0.02%     
==========================================
  Files         197      197              
  Lines       14929    14929              
==========================================
- Hits        12843    12841       -2     
- Misses       1776     1778       +2     
  Partials      310      310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2023
@ReToCode
Copy link
Member

/override "https_serving_main"

Copy link

knative-prow bot commented Nov 16, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: https_serving_main

In response to this:

/override "https_serving_main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

/retest

@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from 7c69a4f to 4138289 Compare November 17, 2023 11:05
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
bumping knative.dev/net-certmanager 8b2a470...67dcf8f:
  > 67dcf8f upgrade to latest dependencies (# 628)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from 4138289 to 951fe75 Compare November 20, 2023 11:05
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
Copy link

knative-prow bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

/override "https_serving_main"

Copy link

knative-prow bot commented Nov 20, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: https_serving_main

In response to this:

/override "https_serving_main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 7526e62 into knative:main Nov 20, 2023
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants