Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Serving encryption documentation to the newest developments #14631

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

ReToCode
Copy link
Member

Proposed Changes

  • Update Serving encryption documentation to the newest developments

/assign @dprotaso
/cc @nak3
/cc @skonto
/cc @KauzClay

@knative-prow knative-prow bot requested review from KauzClay, nak3 and skonto November 16, 2023 11:54
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7561386) 86.02% compared to head (6c424ed) 86.06%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14631      +/-   ##
==========================================
+ Coverage   86.02%   86.06%   +0.04%     
==========================================
  Files         197      197              
  Lines       14929    14937       +8     
==========================================
+ Hits        12843    12856      +13     
+ Misses       1776     1772       -4     
+ Partials      310      309       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member Author

/retest

@skonto
Copy link
Contributor

skonto commented Nov 20, 2023

CN/SAN reference at the bottom should be removed or used to indicate the SAN name for an individual ksvc?
Just want to clarify that we are using SNI.

@skonto
Copy link
Contributor

skonto commented Nov 20, 2023

LGTM waiting for the others.

@ReToCode
Copy link
Member Author

CN/SAN reference at the bottom should be removed or used to indicate the SAN name for an individual ksvc?
Just want to clarify that we are using SNI.

Done.

@dprotaso
Copy link
Member

encryption-system-internal.drawio.svg

I think the 'use' arrows are inverted. Cause I don't think of a secret as using the activator - but the other way around.

@ReToCode
Copy link
Member Author

I think the 'use' arrows are inverted. Cause I don't think of a secret as using the activator - but the other way around.

👍 Right, fixed it.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
Copy link

knative-prow bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8e63c1a into knative:main Nov 23, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants