-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Serving encryption documentation to the newest developments #14631
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14631 +/- ##
==========================================
+ Coverage 86.02% 86.06% +0.04%
==========================================
Files 197 197
Lines 14929 14937 +8
==========================================
+ Hits 12843 12856 +13
+ Misses 1776 1772 -4
+ Partials 310 309 -1 ☔ View full report in Codecov by Sentry. |
/retest |
CN/SAN reference at the bottom should be removed or used to indicate the SAN name for an individual ksvc? |
LGTM waiting for the others. |
Done. |
I think the 'use' arrows are inverted. Cause I don't think of a secret as using the activator - but the other way around. |
👍 Right, fixed it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
/assign @dprotaso
/cc @nak3
/cc @skonto
/cc @KauzClay