Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #14959

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 8bbe335...185dad3:
  > 185dad3 upgrade to latest dependencies (# 676)

bumping knative.dev/net-certmanager 8bbe335...185dad3:
  > 185dad3 upgrade to latest dependencies (# 676)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from bf4194b to aa84aea Compare February 28, 2024 11:05
@knative-prow knative-prow bot requested a review from a team February 28, 2024 11:05
Copy link

knative-prow bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign creydr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (a1ad60a) to head (aa84aea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14959   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files         213      213           
  Lines       16635    16635           
=======================================
  Hits        14013    14013           
  Misses       2277     2277           
  Partials      345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

knative-prow bot commented Feb 28, 2024

@knative-automation: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
https_serving_main aa84aea link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow knative-prow bot merged commit cdb41a4 into knative:main Feb 28, 2024
45 of 46 checks passed
andrew-delph pushed a commit to andrew-delph/serving that referenced this pull request Mar 14, 2024
bumping knative.dev/net-certmanager 8bbe335...185dad3:
  > 185dad3 upgrade to latest dependencies (# 676)

Signed-off-by: Knative Automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant