Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-activate disabled istio tls tests #14995

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Re-activate disabled istio tls tests #14995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/kind-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
- kourier
- kourier-tls
- istio
# - istio-tls
- istio-tls
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
# - istio-ambient
- contour
Expand All @@ -116,10 +116,10 @@ jobs:
- ingress: istio
namespace-resources: virtualservices

# - ingress: istio-tls
# ingress-class: istio
# namespace-resources: virtualservices
# enable-tls: 1
- ingress: istio-tls
ingress-class: istio
namespace-resources: virtualservices
enable-tls: 1

# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
# - ingress: istio-ambient
Expand Down
5 changes: 3 additions & 2 deletions test/e2e/systeminternaltls/system_internal_tls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ func TestSystemInternalTLS(t *testing.T) {
t.Skip("Alpha features not enabled")
}

if !strings.Contains(test.ServingFlags.IngressClass, "kourier") {
t.Skip("Skip this test for non-kourier ingress.")
if !(strings.Contains(test.ServingFlags.IngressClass, "kourier") ||
strings.Contains(test.ServingFlags.IngressClass, "istio")) {
t.Skip("Skip this test for non-kourier or non-istio ingress.")
}

t.Parallel()
Expand Down
Loading