Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contour-gateway.yaml to third_party folder #14998

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented Mar 11, 2024

Changes

  • Add contour-gateway.yaml to third_party/gateway-api-latest folder

PS: this PR is just to speed things up, the contour-gateway.yaml file will be added automatically as part of the following nightly job (starting tomorrow): knative-extensions/knobots#372

Part of #14983

@knative-prow knative-prow bot requested review from ReToCode and skonto March 11, 2024 15:30
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/networking labels Mar 11, 2024
@izabelacg
Copy link
Member Author

/assign @dprotaso

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (88abc84) to head (51ffff1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14998      +/-   ##
==========================================
- Coverage   84.08%   84.06%   -0.02%     
==========================================
  Files         213      213              
  Lines       16687    16687              
==========================================
- Hits        14031    14028       -3     
- Misses       2303     2306       +3     
  Partials      353      353              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

The test scripts assume only gateway+istio so it tries to apply everything in the folder

 kapp: Error: Uniqueness errors:
- Found resource 'configmap/config-gateway (v1) namespace: 3fc12db6-02b2-4ab0-a1b8-a46d5dba5b55' multiple times with different content
exit status 1 

serving/test/e2e-common.sh

Lines 285 to 287 in 455d3e5

# This installs an istio version that works with the v1alpha1 gateway api
YTT_FILES+=("${E2E_YAML_DIR}/gateway-api/install")
YTT_FILES+=("${REPO_ROOT_DIR}/third_party/${ingress}-latest")

@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Mar 11, 2024
@izabelacg
Copy link
Member Author

Hmm... it means then once the nightly job runs and adds contour-gateway.yaml, the tests are gonna fail for others PRs too, right? Let me know if the workaround I just pushed would be ok for now. Then I can open another PR with that workaround just to make sure things don't break after the nightly runs. And I can keep working on a definite solution to switch/select between contour / istio + gateway api

@izabelacg
Copy link
Member Author

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

yeah this is fine for now

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link

knative-prow bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@knative-prow knative-prow bot merged commit 3e119d5 into knative:main Mar 11, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants