-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contour-gateway.yaml to third_party folder #14998
Conversation
/assign @dprotaso |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14998 +/- ##
==========================================
- Coverage 84.08% 84.06% -0.02%
==========================================
Files 213 213
Lines 16687 16687
==========================================
- Hits 14031 14028 -3
- Misses 2303 2306 +3
Partials 353 353 ☔ View full report in Codecov by Sentry. |
The test scripts assume only gateway+istio so it tries to apply everything in the folder
Lines 285 to 287 in 455d3e5
|
Hmm... it means then once the nightly job runs and adds contour-gateway.yaml, the tests are gonna fail for others PRs too, right? Let me know if the workaround I just pushed would be ok for now. Then I can open another PR with that workaround just to make sure things don't break after the nightly runs. And I can keep working on a definite solution to switch/select between contour / istio + gateway api |
… with contour-gateway.yaml
f40a86d
to
51ffff1
Compare
/retest |
/lgtm yeah this is fine for now |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, izabelacg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
PS: this PR is just to speed things up, the contour-gateway.yaml file will be added automatically as part of the following nightly job (starting tomorrow): knative-extensions/knobots#372
Part of #14983