[TEST] [WIP] Debug https_serving_main

test/e2e-common.sh

@@ -321,7 +321,7 @@ function install() {
   fi
 
   if (( ENABLE_HA )); then
-    YTT_FILES+=("${E2E_YAML_DIR}/test/config/chaosduck/chaosduck.yaml")
+#    YTT_FILES+=("${E2E_YAML_DIR}/test/config/chaosduck/chaosduck.yaml")
     YTT_FILES+=("${REPO_ROOT_DIR}/test/config/ytt/ha")
   fi
 
@@ -401,6 +401,12 @@ function install() {
     kubectl delete pod -n ${SYSTEM_NAMESPACE} -l app=activator
     kubectl wait --timeout=60s --for=condition=Available deployment  -n ${SYSTEM_NAMESPACE} activator
   fi
+
+  echo "Enable request logging etc"
+  toggle_feature "loglevel.activator" debug config-logging
+  toggle_feature "loglevel.queueproxy" debug config-logging
+  toggle_feature "logging.enable-request-log" true config-observability
+  toggle_feature "logging.enable-probe-request-log" true config-observability
 }
 
 # Check if we should use --resolvabledomain.  In case the ingress only has

test/e2e-tests.sh

@@ -85,15 +85,15 @@ toggle_feature cluster-local-domain-tls enabled config-network || fail_test
 go_test_e2e -timeout=2m ./test/e2e/clusterlocaldomaintls ${E2E_TEST_FLAGS} || failed=1
 toggle_feature cluster-local-domain-tls disabled config-network || fail_test
 
-toggle_feature system-internal-tls enabled config-network || fail_test
-toggle_feature "logging.enable-request-log" true config-observability || fail_test
-toggle_feature "logging.request-log-template" "TLS: {{.Request.TLS}}" config-observability || fail_test
-# with current implementation, Activator must be restarted when configuring system-internal-tls. See https://github.com/knative/serving/issues/13754
-restart_pod ${SYSTEM_NAMESPACE} "app=activator"
-go_test_e2e -timeout=2m ./test/e2e/systeminternaltls ${E2E_TEST_FLAGS} || failed=1
-toggle_feature system-internal-tls disabled config-network || fail_test
-toggle_feature enable-request-log false config-observability || fail_test
-toggle_feature request-log-template '' config-observability || fail_test
+#toggle_feature system-internal-tls enabled config-network || fail_test
+#toggle_feature "logging.enable-request-log" true config-observability || fail_test
+#toggle_feature "logging.request-log-template" "TLS: {{.Request.TLS}}" config-observability || fail_test
+## with current implementation, Activator must be restarted when configuring system-internal-tls. See https://github.com/knative/serving/issues/13754
+#restart_pod ${SYSTEM_NAMESPACE} "app=activator"
+#go_test_e2e -timeout=2m ./test/e2e/systeminternaltls ${E2E_TEST_FLAGS} || failed=1
+#toggle_feature system-internal-tls disabled config-network || fail_test
+##toggle_feature enable-request-log false config-observability || fail_test
+#toggle_feature request-log-template '' config-observability || fail_test
 # with the current implementation, Activator is always in the request path, and needs to be restarted after configuring system-internal-tls
 restart_pod ${SYSTEM_NAMESPACE} "app=activator"
 

test/e2e/autoscale_hpa_test.go

@@ -90,11 +90,12 @@ func setupHPASvc(t *testing.T, metric string, target int) *TestContext {
 	resources, err := v1test.CreateServiceReady(t, clients, names,
 		[]rtesting.ServiceOption{
 			rtesting.WithConfigAnnotations(map[string]string{
-				autoscaling.ClassAnnotationKey:    autoscaling.HPA,
-				autoscaling.MetricAnnotationKey:   metric,
-				autoscaling.TargetAnnotationKey:   strconv.Itoa(target),
-				autoscaling.MaxScaleAnnotationKey: fmt.Sprintf("%d", int(maxPods)),
-				autoscaling.WindowAnnotationKey:   "20s",
+				autoscaling.ClassAnnotationKey:          autoscaling.HPA,
+				autoscaling.MetricAnnotationKey:         metric,
+				autoscaling.TargetAnnotationKey:         strconv.Itoa(target),
+				autoscaling.MaxScaleAnnotationKey:       fmt.Sprintf("%d", int(maxPods)),
+				autoscaling.WindowAnnotationKey:         "20s",
+				"features.knative.dev/http-full-duplex": "Enabled",
 			}), rtesting.WithResourceRequirements(corev1.ResourceRequirements{
 				Requests: corev1.ResourceList{
 					corev1.ResourceCPU:    resource.MustParse("30m"),

test/e2e/autoscale_test.go

@@ -138,6 +138,7 @@ func TestAutoscaleSustaining(t *testing.T) {
 				test.Options{},
 				rtesting.WithConfigAnnotations(map[string]string{
 					autoscaling.MetricAggregationAlgorithmKey: algo,
+					"features.knative.dev/http-full-duplex":   "Enabled",
 				}))
 			test.EnsureTearDown(t, ctx.Clients(), ctx.Names())
 

third_party/cert-manager-latest/net-certmanager.yaml

@@ -214,7 +214,7 @@ spec:
               memory: 40Mi
             limits:
               cpu: 300m
-              memory: 400Mi
+              memory: 600Mi
           env:
             - name: SYSTEM_NAMESPACE
               valueFrom:

vendor/knative.dev/pkg/test/logstream/interface.go

@@ -1,4 +1,4 @@
 /*
 Copyright 2019 The Knative Authors
 
 Licensed under the Apache License, Version 2.0 (the "License");
@@ -24,7 +24,6 @@
 	"sync"
 
 	"k8s.io/client-go/kubernetes"
-	"knative.dev/pkg/system"
 	"knative.dev/pkg/test"
 	"knative.dev/pkg/test/helpers"
 	logstreamv2 "knative.dev/pkg/test/logstream/v2"
@@ -49,7 +48,7 @@
 func Start(t ti) Canceler {
 	// Do this lazily to make import ordering less important.
 	once.Do(func() {
-		if ns := os.Getenv(system.NamespaceEnvKey); ns != "" {
+		if ns := os.Getenv("serving-tests"); ns != "" {
 			var err error
 			// handle case when ns contains a csv list
 			namespaces := strings.Split(ns, ",")