Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod diagnostics before scaling down to zero in scaler #15326

Closed
wants to merge 2 commits into from

fix ctx

248d6e8
Select commit
Loading
Failed to load commit list.
Closed

Add pod diagnostics before scaling down to zero in scaler #15326

fix ctx
248d6e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2024 in 1s

84.60% (target 80.00%)

View this Pull Request on Codecov

84.60% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (62ce45c) to head (248d6e8).
Report is 144 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/autoscaling/kpa/scaler.go 21.05% 13 Missing and 2 partials ⚠️
pkg/resources/pods.go 0.00% 7 Missing ⚠️
pkg/apis/autoscaling/v1alpha1/pa_lifecycle.go 0.00% 2 Missing ⚠️
pkg/reconciler/autoscaling/kpa/kpa.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15326      +/-   ##
==========================================
- Coverage   84.76%   84.60%   -0.16%     
==========================================
  Files         218      218              
  Lines       13504    13534      +30     
==========================================
+ Hits        11447    11451       +4     
- Misses       1690     1713      +23     
- Partials      367      370       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov